Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend certificate validity #95

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

ignasi35
Copy link
Member

@ignasi35 ignasi35 commented Apr 8, 2020

Working on akka/akka-grpc#352 I tried to use the certificates in play-scala-tls-example just to be bitten by expired certificates.

Turn out #77 was incomplete and was only extending the duration of some elements (but not the certificates).

@ignasi35 ignasi35 requested review from raboof and octonato April 8, 2020 19:18
@octonato
Copy link
Contributor

octonato commented Apr 9, 2020

Thanks @ignasi35.

@ignasi35
Copy link
Member Author

ignasi35 commented Apr 9, 2020

Mergify! Y U NO MERGE?!

@ignasi35 ignasi35 merged commit 75fcbff into playframework:2.8.x Apr 9, 2020
@ignasi35 ignasi35 deleted the extend-certificate-validity branch April 9, 2020 16:29
ignasi35 pushed a commit to ignasi35/play-samples that referenced this pull request May 20, 2020
….6.x

* play-java-starter-example/2.6.x: (57 commits)
  Nest play-java-starter-example
  Updated with template-control on 2019-02-13T20:25:39.664Z (playframework#103)
  Upgrade branch 2.6.x using TemplateControl (playframework#99)
  Upgrade branch 2.6.x using TemplateControl (playframework#98)
  Upgrade branch 2.6.x using TemplateControl (playframework#97)
  Updated with template-control on 2019-01-08T14:44:42.254Z (playframework#95)
  Updated with template-control on 2019-01-04T17:13:24.036Z (playframework#90)
  Upgrade branch 2.6.x using TemplateControl (playframework#89)
  Improve README (playframework#81)
  Upgrade branch 2.6.x using TemplateControl (playframework#79)
  Updated with template-control on 2018-09-11T20:14:50.628Z (playframework#78)
  Updated with template-control on 2018-08-20T20:37:14.072Z (playframework#77)
  Updated with template-control on 2018-07-19T01:58:56.147Z (playframework#74)
  Updated with template-control on 2018-07-16T18:38:45.658Z (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#71)
  Updated with template-control on 2018-05-27T23:54:09.356Z (playframework#69)
  Updated with template-control on 2018-04-06T19:34:58.808Z (playframework#66)
  Change disabled to enabled (playframework#64)
  Use discuss forum (playframework#62)
  Enable localhost:9000 as allowed host by default. (playframework#61)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this pull request May 20, 2020
* play-scala-anorm-example/2.6.x: (68 commits)
  Nest play-scala-anorm-example
  Updated with template-control on 2019-02-13T20:25:39.764Z (playframework#105)
  Upgrade branch 2.6.x using TemplateControl (playframework#102)
  Upgrade branch 2.6.x using TemplateControl (playframework#101)
  Upgrade branch 2.6.x using TemplateControl (playframework#100)
  Updated with template-control on 2019-01-08T14:44:41.925Z (playframework#98)
  Updated with template-control on 2019-01-04T17:13:23.631Z (playframework#95)
  Fix deprecated WithResult.fold method usage (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#90)
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#89)
  Fix cross build to sbt 1.1.0 (playframework#76)
  Updated with template-control on 2018-07-19T01:58:55.836Z (playframework#87)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#86)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Updated with template-control on 2018-05-27T23:54:09.813Z (playframework#84)
  Updated with template-control on 2018-04-06T19:34:57.924Z (playframework#80)
  Update the README (playframework#82)
  Upgrade Anorm dependency and usage (playframework#81)
  link to playframework version of anorm (playframework#79)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this pull request May 20, 2020
…' into 2.6.x

* play-scala-secure-session-example/2.6.x: (70 commits)
  Nest play-scala-secure-session-example
  Updated with template-control on 2019-02-13T20:17:46.435Z (playframework#95)
  Updated with template-control on 2019-02-01T10:40:32.758Z (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#92)
  Upgrade branch 2.6.x using TemplateControl (playframework#91)
  Upgrade branch 2.6.x using TemplateControl (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#82)
  Upgrade branch 2.6.x using TemplateControl (playframework#81)
  adds mergify file (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#77)
  Updated with template-control on 2018-08-20T20:37:13.861Z (playframework#71)
  Updated with template-control on 2018-07-19T01:58:55.998Z (playframework#69)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#68)
  Upgrade branch 2.6.x using TemplateControl (playframework#66)
  Updated with template-control on 2018-05-27T23:54:09.617Z (playframework#65)
  Updated with template-control on 2018-04-06T19:34:58.475Z (playframework#63)
  Updated with template-control on 2018-03-02T18:56:28.210Z (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Fix cross build to sbt 1.1.0 (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this pull request May 20, 2020
…2.6.x

* play-scala-starter-example/2.6.x: (68 commits)
  Nest play-scala-starter-example
  Updated with template-control on 2019-02-13T20:25:39.621Z (playframework#120)
  Change user action from clicking to refreshing (playframework#99)
  Upgrade branch 2.6.x using TemplateControl (playframework#117)
  Upgrade branch 2.6.x using TemplateControl (playframework#116)
  Upgrade branch 2.6.x using TemplateControl (playframework#115)
  Updated with template-control on 2019-01-08T14:44:42.057Z (playframework#113)
  Updated with template-control on 2019-01-04T17:13:24.100Z (playframework#108)
  Upgrade branch 2.6.x using TemplateControl (playframework#105)
  Updated with template-control on 2018-11-16T14:25:15.398Z (playframework#103)
  Remove jdk 9 & 10 (playframework#97)
  Upgrade to Scala 2.12.7 (playframework#95)
  Improve README (playframework#96)
  Upgrade branch 2.6.x using TemplateControl (playframework#94)
  Updated with template-control on 2018-09-11T20:14:50.648Z (playframework#93)
  Updated with template-control on 2018-08-20T20:37:14.070Z (playframework#92)
  Updated with template-control on 2018-07-19T01:58:56.055Z (playframework#90)
  Updated with template-control on 2018-07-16T18:38:45.679Z (playframework#89)
  Add jdk 10 & 11 to Travis build (playframework#86)
  Scala 2.12.6 (playframework#88)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants